Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonar fixes for critical, major and minor issues #62

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Sonar fixes for critical, major and minor issues #62

merged 3 commits into from
Oct 15, 2024

Conversation

sachin-apa
Copy link
Collaborator

@sachin-apa sachin-apa commented May 29, 2024 •
edited
Loading

Description

Fixing sonar issues for powerflex.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test

@sachin-apa sachin-apa changed the title sonar fixes for critical, major and minor issues Sonar fixes for critical, major and minor issues May 29, 2024
@sachin-apa sachin-apa requested review from Kritika-Bhateja-03 and removed request for Jennifer-John and felixs88 October 15, 2024 04:42
@sachin-apa sachin-apa merged commit 4b42618 into dell:main Oct 15, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meenakshidembi691 meenakshidembi691 meenakshidembi691 approved these changes

@trisha-dell trisha-dell trisha-dell approved these changes

@Bhavneet-Sharma Bhavneet-Sharma Awaiting requested review from Bhavneet-Sharma Bhavneet-Sharma is a code owner

@Kritika-Bhateja-03 Kritika-Bhateja-03 Awaiting requested review from Kritika-Bhateja-03

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sachin-apa @meenakshidembi691 @trisha-dell